Skip to content

Parse .flutter-plugins-dependencies for add-to-app iOS modules #61269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Jul 28, 2020
Merged

Parse .flutter-plugins-dependencies for add-to-app iOS modules #61269

fluttergithubbot merged 2 commits into from
Jul 28, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jul 10, 2020

Description

Parse .flutter-plugins-dependencies in Flutter modules to not pull in plugins that don't support iOS. Pretty close to #59209 but for the module template.

Related Issues

Fixes #59811
#59209

Tests

Updated module_test_ios to depend on android_alarm_manager, then make sure there's no android_alarm_manager embedded in the host app.

@jmagman jmagman added platform-ios iOS applications specifically a: existing-apps Integration with existing apps via the add-to-app flow labels Jul 10, 2020
@jmagman jmagman self-assigned this Jul 10, 2020
@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 10, 2020
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jul 10, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

christopherfujino
christopherfujino reviewed Jul 10, 2020
View reviewed changes
packages/flutter_tools/templates/module/ios/library/Flutter.tmpl/podhelper.rb.tmpl Outdated
Copy link
Contributor

@christopherfujino christopherfujino Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is defined_in_file? is this a pod magic function?

Copy link
Contributor

@christopherfujino christopherfujino Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I grepped the codebase and found y our other comments about it

Copy link
Member Author

@jmagman jmagman Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the comments to this file.

xster
xster reviewed Jul 10, 2020
View reviewed changes
Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! LGTM

packages/flutter_tools/templates/module/ios/library/Flutter.tmpl/podhelper.rb.tmpl Outdated
Copy link
Member

@xster xster Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a code comment or reference issue for when this can happen?

Copy link
Member Author

@jmagman jmagman Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it can ever happen AFAIK, I think I just wanted a way to surface Something Bad Happened and stopping instead of copying from a nonexistent directory in https://github.com/flutter/flutter/pull/59044/files#diff-76053fa099530bf75a339336cccbc2efR23.

@jmagman jmagman mentioned this pull request Jul 23, 2020
Merged
13 tasks
@jmagman jmagman force-pushed the add-to-app-podhelper branch from 0d1fb59 to 067483a Compare July 28, 2020 02:24
@jmagman jmagman mentioned this pull request Jul 28, 2020
Merged
@fluttergithubbot fluttergithubbot merged commit e8e5de4 into flutter:master Jul 28, 2020
@jmagman jmagman deleted the add-to-app-podhelper branch July 28, 2020 17:29
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@jmagman @Pragya007
Parse .flutter-plugins-dependencies for add-to-app iOS modules (flutt…
ebbd24b 
…er#61269)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Parse .flutter-plugins-dependencies for add-to-app iOS modules (flutt…
ba2a386 
…er#61269)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster xster left review comments

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow add-to-app modules to use plugins that don't support iOS (.flutter-plugins-dependencies)

6 participants

@jmagman @fluttergithubbot @xster @zanderso @christopherfujino @googlebot