Skip to content

Port test logic to Dart. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hixie merged 1 commit into from
Nov 9, 2015
Merged

Port test logic to Dart. #61

Hixie merged 1 commit into from
Nov 9, 2015

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Nov 9, 2015

No description provided.

@Hixie
Copy link
Contributor Author

Hixie commented Nov 9, 2015

This gets rid of dev/run_tests and packages/flutter_tools/bin/sky_test.dart. Now to run the tests you just run flutter test --debug.

cc @abarth

@Hixie Hixie force-pushed the dart-tests branch 3 times, most recently from c61c90d to e891116 Compare November 9, 2015 09:03
abarth
abarth reviewed Nov 9, 2015
View reviewed changes
packages/flutter_tools/lib/src/commands/flutter_command_runner.dart
Copy link
Contributor

@abarth abarth Nov 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy

@abarth
Copy link
Contributor

abarth commented Nov 9, 2015

LGTM

Would you be willing to update CONTRIBUTING.md as well? Eventually, I'd like to grow flutter test to be useful for end developers as well, but we can worry about that in future patches.

Thanks!

@Hixie Hixie mentioned this pull request Nov 9, 2015
Closed
@Hixie
Copy link
Contributor Author

Hixie commented Nov 9, 2015

Updated as per comments. Will check in if Travis agrees. cc @abarth

Hixie added a commit that referenced this pull request Nov 9, 2015
@Hixie
Merge pull request #61 from Hixie/dart-tests
d355611 
Port test logic to Dart.
@Hixie Hixie merged commit d355611 into flutter:master Nov 9, 2015
@Hixie Hixie deleted the dart-tests branch November 9, 2015 17:11
@mpcomplete mpcomplete mentioned this pull request Apr 20, 2016
Closed
@mpcomplete mpcomplete mentioned this pull request Jun 17, 2016
Closed
@jason-simmons jason-simmons mentioned this pull request Jul 21, 2016
Closed
@mswift42 mswift42 mentioned this pull request Nov 13, 2016
Closed
@gavindoughtie gavindoughtie mentioned this pull request Dec 2, 2016
Closed
@ppolasek ppolasek mentioned this pull request Feb 8, 2017
Closed
@skybrian skybrian mentioned this pull request Feb 16, 2017
Closed
@Reagankm Reagankm mentioned this pull request Feb 24, 2017
Closed
@collinjackson collinjackson mentioned this pull request May 19, 2017
Closed
@jamesgopinath jamesgopinath mentioned this pull request Aug 4, 2017
Closed
@apwilson apwilson mentioned this pull request Aug 10, 2017
Closed
@JFixby JFixby mentioned this pull request Sep 7, 2017
Closed
@gavindoughtie gavindoughtie mentioned this pull request Sep 25, 2017
Closed
@arnold-nonstop arnold-nonstop mentioned this pull request Sep 29, 2017
Closed
@amirh amirh mentioned this pull request Oct 9, 2017
Closed
@PlanovskyJus PlanovskyJus mentioned this pull request Nov 3, 2017
Closed
@ummuhan ummuhan mentioned this pull request Oct 6, 2020
Closed
@JeetBhattachariya JeetBhattachariya mentioned this pull request Oct 8, 2020
Closed
This was referenced Oct 16, 2020
Closed
Closed
Closed
@lv823063712 lv823063712 mentioned this pull request Oct 19, 2020
Closed
@right7ctrl right7ctrl mentioned this pull request Oct 24, 2020
Closed
@hasanworks hasanworks mentioned this pull request Oct 30, 2020
Closed
@Tony-Akani Tony-Akani mentioned this pull request Nov 1, 2020
Closed
@kw2019ltd kw2019ltd mentioned this pull request Nov 16, 2020
Closed
@page-bunnii page-bunnii mentioned this pull request Nov 20, 2020
Closed
@issantech issantech mentioned this pull request Nov 23, 2020
Closed
This was referenced Dec 11, 2020
Closed
Closed
@sureace sureace mentioned this pull request Jan 13, 2021
Closed
@staminna staminna mentioned this pull request Jan 22, 2021
Closed
@yannainghtun-mk yannainghtun-mk mentioned this pull request Jan 26, 2021
Closed
@1005274291 1005274291 mentioned this pull request Jan 26, 2021
Closed
@praneethpj praneethpj mentioned this pull request Jan 29, 2021
Closed
@sravanpabolu sravanpabolu mentioned this pull request Feb 11, 2021
Closed
@lianchengtong lianchengtong mentioned this pull request Feb 13, 2021
Closed
@Marko1994 Marko1994 mentioned this pull request Mar 4, 2021
Closed
@lironzemingo lironzemingo mentioned this pull request Mar 11, 2021
Closed
@bladeofgod bladeofgod mentioned this pull request Apr 14, 2021
Open
@sauravgpt sauravgpt mentioned this pull request Apr 28, 2021
Closed
@SlowGen SlowGen mentioned this pull request May 27, 2021
Closed
@akashgk akashgk mentioned this pull request Jun 18, 2021
Closed
@SamStrike0809 SamStrike0809 mentioned this pull request Jun 18, 2021
Closed
@94wogus 94wogus mentioned this pull request Jul 3, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hixie @abarth