Skip to content

Revert "Fix remaining holes in stack trace demangling"#60916

Merged
dnfield merged 1 commit into
masterfrom
revert-60478-pixeltoast-patch-3
Jul 6, 2020
Merged

Revert "Fix remaining holes in stack trace demangling"#60916
dnfield merged 1 commit into
masterfrom
revert-60478-pixeltoast-patch-3

Conversation

@dnfield

@dnfield dnfield commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

Broke the tree, Reverts #60478

tbr @PixelToast

Here's a failure example: https://cirrus-ci.com/task/6707176263647232

Relevant log section:

Failed to precompile tester:tester:
/root/.pub-cache/hosted/pub.dartlang.org/tester-0.0.1-dev9/lib/src/runner.dart:107:5: Error: 'unawaited' is imported from both 'package:meta/meta.dart' and 'package:pedantic/pedantic.dart'.
    unawaited(_process.exitCode.whenComplete(() {
    ^^^^^^^^^
/root/.pub-cache/hosted/pub.dartlang.org/tester-0.0.1-dev9/lib/src/runner.dart:174:5: Error: 'unawaited' is imported from both 'package:meta/meta.dart' and 'package:pedantic/pedantic.dart'.
    unawaited(_process.exitCode.whenComplete(() {
    ^^^^^^^^^
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
ERROR: Last command exited with 1 (expected: zero).
Command: ../../bin/cache/dart-sdk/bin/pub global activate tester 0.0.1-dev9
Relative working directory: packages/flutter_tools
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━```

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 6, 2020
@dnfield
dnfield merged commit 2c7e5dd into master Jul 6, 2020
@dnfield
dnfield deleted the revert-60478-pixeltoast-patch-3 branch July 6, 2020 17:07
@jonahwilliams

Copy link
Copy Markdown
Contributor

This was not caused this PR.

@jonahwilliams
jonahwilliams restored the revert-60478-pixeltoast-patch-3 branch July 6, 2020 17:32
jonahwilliams pushed a commit that referenced this pull request Jul 6, 2020
@dnfield
dnfield deleted the revert-60478-pixeltoast-patch-3 branch July 6, 2020 17:50
dnfield added a commit that referenced this pull request Jul 7, 2020
dnfield added a commit that referenced this pull request Jul 7, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants