[PageTransitionsBuilder] Reland Fix 'ZoomPageTransition' built more than once #60245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: material design
|
Started Google testing for this PR |
Contributor
Author
|
@renyou Unrelated to the PR itself, but does/should the |
Contributor
|
Don't think so. Still working on it.
…On Wed, Jun 24, 2020, 7:27 PM Shi-Hao Hong ***@***.***> wrote:
@renyou <https://github.com/renyou> Unrelated to the PR itself, but
does/should the waiting for tree to go green label account for Google
testing for the PR? I was thinking of the case where this PR merges before
we get a result from Google testing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#60245 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFCW2QOATAUBCF7FOBGGYTRYKDVFANCNFSM4OHOLMFA>
.
|
fluttergithubbot
deleted the
revert-59992-revert-58686-fix-zoom-page-transition-build
branch
|
Google testing passed! |
shihaohong
changed the title
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…lt more than once (flutter#58686)" (flutter#59992)" (flutter#60245)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This has been unblocked internally via cl/318079801. b/159779895 was added to track fixing the tests that were originally preventing #58686 from landing.
cc/ @AlexVincent525
Issues
Fixes #58686
Reverts #59992