Skip to content

Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once" #59992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renyou merged 1 commit into from
Jun 23, 2020
Merged

Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once" #59992

renyou merged 1 commit into from
Jun 23, 2020

Conversation

@renyou
Copy link
Contributor

@renyou renyou commented Jun 22, 2020

This breaks Google internal tests: b/159612674

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 22, 2020
@renyou renyou requested a review from shihaohong June 22, 2020 16:01
@renyou renyou requested a review from Hixie June 22, 2020 16:01
shihaohong
shihaohong approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc/ @AlexVincent525, who worked on the PR. I'll try to debug this issue internally, since I'm not sure how this change would have broken the test in question.

@AlexV525
Copy link
Member

AlexV525 commented Jun 23, 2020

cc/ @AlexVincent525, who worked on the PR.

Thanks for letting me know, I'll keep in touch with this one.

@renyou renyou merged commit 15a2815 into master Jun 23, 2020
@renyou renyou deleted the revert-58686-fix-zoom-page-transition-build branch June 23, 2020 11:53
@AlexV525 AlexV525 mentioned this pull request Jun 23, 2020
Closed
shihaohong pushed a commit that referenced this pull request Jun 24, 2020
Revert "Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' bui…
e17f914 
…lt more than once (#58686)" (#59992)"

This reverts commit 15a2815.
@shihaohong shihaohong mentioned this pull request Jun 24, 2020
Merged
fluttergithubbot pushed a commit that referenced this pull request Jun 25, 2020
Revert "Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' bui…
17cb865 
…lt more than once (#58686)" (#59992)" (#60245)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@renyou @mingwandroid
Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more …
9f19d9d 
…than once (flutter#58686)" (flutter#59992)

This reverts commit fe15d1e.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mingwandroid
Revert "Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' bui…
a7ccb4e 
…lt more than once (flutter#58686)" (flutter#59992)" (flutter#60245)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Awaiting requested review from Hixie

1 more reviewer

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@renyou @AlexV525 @shihaohong @googlebot @fluttergithubbot