suppress pub override warning; decouple the analyzer versions #5991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM assuming "flutter analyze --flutter-repo" still works. (That command gets mad if we have version mismatches.) I'm pretty sure travis runs that check, so it must be ok. Thanks! |
Contributor
|
Awesome. Thanks for following this thread. It didn't occur to me to selectively unpin the dep but that's effectively what we're doing so this makes perfect sense. LGTM! |
Contributor
Author
Yup, that still works, and the update-packages command as well.
Yeah, making that decision definitely makes the problem simpler. |
Hixie
reviewed
Sep 22, 2016
| echo Building flutter tool... | ||
| FLUTTER_DIR="$FLUTTER_ROOT/packages/flutter" | ||
| (cd "$FLUTTER_TOOLS_DIR"; "../../bin/cache/dart-sdk/bin/pub" get --verbosity=warning) | ||
| (cd "$FLUTTER_TOOLS_DIR"; "../../bin/cache/dart-sdk/bin/pub" get --verbosity=error --no-packages-dir) |
Contributor
There was a problem hiding this comment.
what other warnings might this one day mute? I'm worried we're going to miss early warnings of potential breakage...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different attempt at fixing #5925:
bin/flutterand influtter_tools/lib/src/dart/pub.dartflutter_tools; this is the only package we have that uses the analyzer API directlydevicelab/pubspec.yamlandflutter_test/pubspec.yaml; we get the version thatpackage:testspecifies that it needs in its pubspec--no-packages-dirin bin/flutter, to mirror what we do when driving pub from dart code)I think allowing the analyzer version to be different - that used by flutter_tools, and that used by packages that user code will depend on - is ok.
flutter_toolsis generally just a snapshot that users interact with, not something they're actively importing into their codebase. And this lets us use the exact same version of the analyzer as the SDK tools, which is nice - we won't have any version skew between analysis server based products andflutter analyze.@danrubel @Hixie @abarth @pq