Export characters #59620
Merged
Export characters #59620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
framework
justinmc
commented
Jun 17, 2020
| library widgets; | ||
|
|
||
| export 'package:vector_math/vector_math_64.dart' show Matrix4; | ||
| export 'package:characters/characters.dart'; |
Contributor
Author
There was a problem hiding this comment.
Is there a better place to export this?
Contributor
There was a problem hiding this comment.
This seems like the best option in lib/*.dart
Member
|
Exporting this lgtm from a Dart PoV! |
HansMuller
approved these changes
Jun 17, 2020
| library widgets; | ||
|
|
||
| export 'package:vector_math/vector_math_64.dart' show Matrix4; | ||
| export 'package:characters/characters.dart'; |
Contributor
There was a problem hiding this comment.
This seems like the best option in lib/*.dart
Contributor
Author
|
I'm holding off on merging this PR while I fix some logistical problems that caused #53381 to be reverted. |
|
Google testing failed... |
Contributor
Author
|
This or #59778 appears to have broken google3 despite my CL to add characters to google3. I must be missing some step. |
vasilich6107
added a commit
to artflutter/whatsup_flutter_june2020
that referenced
this pull request
Jul 4, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently landed support for Dart's characters package in #59267. In order to encourage developers to use it in their own projects, what if we export it as a part of Flutter?
Previously, users that wanted to properly handle emojis in Flutter had to install and import the characters package before they could do that. With this PR, they would automatically have access to
string.characterswherever they're using Flutter. This makes the barrier much lower for properly handling complex characters.Related Issues
Closes #55593
Tests
I tested that the characters package is available and works without importing/installing it.
Breaking Change
None