Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jun 15, 2020

Description

package release hash build codesigned
libimobiledevice 1.3.0 569016da35ccea9d9b7c81954342fabb98149fb5 build yes
libusbmuxd 2.0.2 ce98c346b7c1dc2a21faea4fd3f32c88e27ca2af build yes
libplist 2.2.0 20a2f8dbddcf1a96ad4c720b9afd1d0876d17ffc build yes
libtasn1 4.16.0 78204593822b4c1a8e0ca87f57c48e5936b0fe2c n/a n/a
openssl 1.1.1g e2e09d9fba1187f8d6aafaa34d4172f56f1ffb72 build yes
libusb 1.0.23 e782eeb2514266f6738e242cdcb18e3ae1ed06fa n/a n/a

Related Issues

Fixes #59506

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@jmagman
Copy link
Member

jmagman commented Jun 16, 2020

I locally smoke tested upgraded libimobiledevice, libusbmuxd, libplist (not openssl, etc) and it seemed to all work.

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 18, 2020
@christopherfujino christopherfujino force-pushed the update-libimobiledevice branch from b490ce1 to 1cb3b26 Compare June 26, 2020 00:18
@jmagman jmagman force-pushed the update-libimobiledevice branch from 1fb8e48 to 4e914da Compare June 26, 2020 22:06
@christopherfujino christopherfujino marked this pull request as ready for review June 26, 2020 22:32
@christopherfujino
Copy link
Contributor Author

I should land #60391 before this one.

Copy link
Contributor Author

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmagman your changes LGTM. Can I get your approval too?

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@christopherfujino christopherfujino merged commit 32000db into flutter:master Jun 29, 2020
@christopherfujino christopherfujino deleted the update-libimobiledevice branch June 29, 2020 20:23
christopherfujino added a commit that referenced this pull request Jun 29, 2020
christopherfujino added a commit that referenced this pull request Jun 29, 2020
@christopherfujino
Copy link
Contributor Author

Reverted because of #60559

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update packaged libimobiledevice to latest

5 participants