-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[flutter_tools] update libimobiledevice #59512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] update libimobiledevice #59512
Conversation
|
I locally smoke tested upgraded libimobiledevice, libusbmuxd, libplist (not openssl, etc) and it seemed to all work. |
b490ce1 to
1cb3b26
Compare
1fb8e48 to
4e914da
Compare
|
I should land #60391 before this one. |
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmagman your changes LGTM. Can I get your approval too?
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤞
This reverts commit 32000db.
|
Reverted because of #60559 |
…tter#60551) This reverts commit 32000db.
…" (flutter#60551)" (flutter#60569) This reverts commit 09cca73.
Description
Related Issues
Fixes #59506
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.