Revert "Roll Engine from 965fbbed1776 to 801559ac4ed3 (50 revisions)" #59490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e02265d.
Contributor
Author
|
/cc @gw280 who I think is sherrif right now. |
Contributor
|
Not looking good. Investigating |
Contributor
Author
|
Most likely culprit seems to be Dart roll, since it seems like all mac specific VM Service connection failures. |
Contributor
|
LGTM |
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
…9384)" (flutter#59490) This reverts commit e02265d.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…9384)" (flutter#59490) This reverts commit e02265d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #59384
This made the devicelab very red.
TBR @iskakaushik