Change the definition of MainAxisSize #5931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
abarth
force-pushed
the
new_main_axis_size
branch
from
a9d8c0a to
7462c0d
Compare
Hixie
reviewed
Sep 19, 2016
Contributor
There was a problem hiding this comment.
maybe mention the constraints minWidth here?
Hixie
reviewed
Sep 19, 2016
Hixie
reviewed
Sep 19, 2016
Contributor
There was a problem hiding this comment.
maybe mention that a tight flexible child is going to make this get essentially ignored?
Contributor
|
|
This property now applies only to the free space in the flex layout (i.e., minimize or maximize the amount of free space). Previously, the flexible children were always allocated a size of zero when MainAxisSize was min. Now they're allocated the same size that would be if the MainAxisSize was max.
abarth
force-pushed
the
new_main_axis_size
branch
from
7462c0d to
d206a23
Compare
engine-flutter-autoroll
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2018
flutter/engine@a76054f...3b66f20 git log a76054f..3b66f20 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter#5931) 2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter#5930) 2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter#5928) 2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter#5924) 2018-08-02 37626415+[email protected] Roll src/third_party/skia e43024a5bab7..64cc576b1fa7 (1 commits) (flutter#5926) 2018-08-01 37626415+[email protected] Roll src/third_party/skia ed8bc196bd56..e43024a5bab7 (1 commits) (flutter#5925) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2018
flutter/engine@4893b07...3b66f20 git log 4893b07..3b66f20 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter#5931) 2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter#5930) 2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter#5928) 2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter#5924) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property now applies only to the free space in the flex layout (i.e.,
minimize or maximize the amount of free space). Previously, the flexible
children were always allocated a size of zero when MainAxisSize was min. Now
they're allocated the same size that would be if the MainAxisSize was max.