Repository navigation
[Material] Redesign Time Picker - #59191
Conversation
JoseAlba
left a comment
There was a problem hiding this comment.
I think if you add Dartpad examples into the TimePicker and TImePickerThemeData class it would be great. That way when someone visits the website they will be able to see the time picker from the API docs.
|
The documentation for |
8e20b35 to
49dc9b1
Compare
HansMuller
left a comment
There was a problem hiding this comment.
Comments for time_picker.dart
Everything looks pretty good; most of the comments are just prove that I looked at everything :-).
HansMuller
left a comment
There was a problem hiding this comment.
The changes LGTM. I think the color properties could be documented a little more clearly; I added a few comments suggestions.
This reverts commit e676024.
|
When will this change be live? @rami-a |
This is already live on Flutter's |
|
So I'm guessing its not in the |
[Material] Redesign Time Picker
[Material] Redesign Time Picker
|
Uh, my users actually reported the 24h dial as a bug and I had to revert this locally. (If this is not the appropriate place to discuss it, which I think is very likely, I'd be grateful if someone could point me to the right venue.) The point of the ring mode for the time picker is to emulate an analog clock; people are used to these, and can tell at a glance what hour it's pointing to. While there is such a thing as 24h analog clocks, those are novelties, and I've never seen someone actually use one. So a 24h ring makes very unintuitive UX, and is therefore basically useless. The PR mentions it reflects the upcoming Material spec. Is that visible anywhere public, or is it internal to Google? Last I checked, the published guidelines said a time picker ‘is not under development’. |
|
hi @lalomartins |
|
@andrelabonte just here or do you want me to contact you by email? My address is… easy to find. It's a private app with a very small audience, but quite international, and I'm very happy to give feedback. The app in which I got feedback basically tracks events. It makes an usually correct guess about when it happened, but gives users the option to edit it. People who gave me feedback love the Material picker because they can type the number if they want, or pick from the dial when they prefer that, and the dial mimics an analog clock, so they know by reflex where the hours and minutes go. When I showed them a version built against Flutter dev, the only complaint I got was that the dial was no longer useful. |
|
Now that 1.20 has been released and the time picker spec has actually been published, I can't help but make two observations:
|
Description
This is a large PR that redesigns the time picker to match the upcoming Material spec. The main changes include:
Related Issues
Fixes #53905
Fixes #56465
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.