ClampOverscrolls clamps Scrollable, not its Viewport #5909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragostis
approved these changes
Sep 16, 2016
Contributor
dragostis
left a comment
dragostis
left a comment
There was a problem hiding this comment.
LGTM. Does this mandate a test?
Contributor
|
This should have a test that demonstrates that this fixes #5709. |
added 6 commits
September 21, 2016 10:48
HansMuller
force-pushed
the
really_clamp_scroll_offset
branch
from
a062783 to
cfa1ac8
Compare
Contributor
|
|
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 31, 2018
flutter/engine@af855e0...5b09e14 git log af855e0..5b09e14 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909) 2018-07-30 [email protected] Add word movement granularities to android (flutter#5902) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908) 2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906) 2018-07-30 [email protected] Replace travis with cirrus (flutter#5899) 2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897) 2018-07-30 [email protected] Add docker container generation scripts (flutter#5898) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905) 2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895) 2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 31, 2018
flutter/engine@af855e0...3e6b681 git log af855e0..3e6b681 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909) 2018-07-30 [email protected] Add word movement granularities to android (flutter#5902) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908) 2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906) 2018-07-30 [email protected] Replace travis with cirrus (flutter#5899) 2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897) 2018-07-30 [email protected] Add docker container generation scripts (flutter#5898) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905) 2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895) 2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 31, 2018
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 31, 2018
flutter/engine@af855e0...d06e9e8 git log af855e0..d06e9e8 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-31 [email protected] Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (flutter#18886) (flutter#5858) 2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909) 2018-07-30 [email protected] Add word movement granularities to android (flutter#5902) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908) 2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906) 2018-07-30 [email protected] Replace travis with cirrus (flutter#5899) 2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897) 2018-07-30 [email protected] Add docker container generation scripts (flutter#5898) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905) 2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895) 2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 31, 2018
flutter/engine@af855e0...91ff524 git log af855e0..91ff524 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 74c6ed3d1f17..1935aa3d27cd (11 commits) (flutter#5911) 2018-07-31 [email protected] Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (flutter#18886) (flutter#5858) 2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909) 2018-07-30 [email protected] Add word movement granularities to android (flutter#5902) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908) 2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906) 2018-07-30 [email protected] Replace travis with cirrus (flutter#5899) 2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897) 2018-07-30 [email protected] Add docker container generation scripts (flutter#5898) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905) 2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895) 2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889) 2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClampOverscrolls widget now actually clamps the scrollable's scrollOffset, rather than its viewport's scrollOffset.
Widgets that depend on seeing the overscroll, even when the scroll offset has been clamped, can use the Scrollable's virtualScrollOffset. The virutalScrollOffset is updated unconditionally.
Fixes #5709