Skip to content

Add FlexFit.loose #5908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abarth merged 1 commit into from
Sep 16, 2016
Merged

Add FlexFit.loose #5908

abarth merged 1 commit into from
Sep 16, 2016

Conversation

@abarth
Copy link
Contributor

@abarth abarth commented Sep 16, 2016

Previously, flexible children were always required to fill their allocated
space. After this change, they can fit loosely into that space and not fill it.
When that happens, the remaining free space is allocated according to the
maixAxisAlignment.

Fixes #5858

@abarth
Copy link
Contributor Author

abarth commented Sep 16, 2016

@Hixie @collinjackson @HansMuller

dragostis
dragostis suggested changes Sep 16, 2016
View reviewed changes
Copy link
Contributor

@dragostis dragostis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good w/ minor nits. Should probably wait for another look over it, though.

packages/flutter/lib/src/rendering/flex.dart Outdated
Copy link
Contributor

@dragostis dragostis Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'is can' -> 'is can'

Copy link
Contributor Author

@abarth abarth Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

packages/flutter/test/rendering/flex_test.dart Outdated
Copy link
Contributor

@dragostis dragostis Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line not necessary.

Copy link
Contributor Author

@abarth abarth Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@Hixie
Copy link
Contributor

Hixie commented Sep 16, 2016

LGTM, but travis is angry.

@Hixie Hixie closed this Sep 16, 2016
@Hixie Hixie reopened this Sep 16, 2016
@Hixie
Copy link
Contributor

Hixie commented Sep 16, 2016

I assume you decided not to redistribute space from a loose flexible to the subsequent flexibles?

@abarth
Add FlexFit.loose
daf4c9f 
Previously, flexible children were always required to fill their allocated
space. After this change, they can fit loosely into that space and not fill it.
When that happens, the remaining free space is allocated according to the
maixAxisAlignment.

Fixes flutter#5858
@dragostis
Copy link
Contributor

dragostis commented Sep 16, 2016

@Hixie Travis will likely pass now.

@abarth
Copy link
Contributor Author

abarth commented Sep 16, 2016

I assume you decided not to redistribute space from a loose flexible to the subsequent flexibles?

Yes, it was much cleaner if they all work within the space allocated to them, and I believe that still addresses the original use case.

@abarth abarth merged commit 3ed4960 into flutter:master Sep 16, 2016
@abarth abarth deleted the flex_fit branch September 16, 2016 20:12
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 31, 2018
Roll engine af855e0..5b09e14 (12 commits)
c1291cf 
flutter/engine@af855e0...5b09e14

git log af855e0..5b09e14 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909)
2018-07-30 [email protected] Add word movement granularities to android (flutter#5902)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908)
2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 31, 2018
Closed
@rmistry rmistry mentioned this pull request Jul 31, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 31, 2018
Roll engine af855e0..3e6b681 (13 commits)
f0e0429 
flutter/engine@af855e0...3e6b681

git log af855e0..3e6b681 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909)
2018-07-30 [email protected] Add word movement granularities to android (flutter#5902)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908)
2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 31, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 31, 2018
Roll engine af855e0..d06e9e8 (14 commits)
e3ed4a9 
flutter/engine@af855e0...d06e9e8

git log af855e0..d06e9e8 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-31 [email protected] Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (flutter#18886) (flutter#5858)
2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909)
2018-07-30 [email protected] Add word movement granularities to android (flutter#5902)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908)
2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 31, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 31, 2018
Roll engine af855e0..91ff524 (15 commits)
f7a50b4 
flutter/engine@af855e0...91ff524

git log af855e0..91ff524 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 74c6ed3d1f17..1935aa3d27cd (11 commits) (flutter#5911)
2018-07-31 [email protected] Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (flutter#18886) (flutter#5858)
2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909)
2018-07-30 [email protected] Add word movement granularities to android (flutter#5902)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908)
2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dragostis dragostis dragostis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flexible needs a flag that decides if the constraints it passes in are loose or tight

3 participants

@abarth @Hixie @dragostis