Repository navigation
Scale input decorator label width - #59010
Merged
fluttergithubbot merged 4 commits intoJun 9, 2020
Merged
Conversation
fluttergithubbot
added
p: material_ui
justinmc
approved these changes
Jun 8, 2020
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
I ran the branch locally and tried to break it but it seems to work in the cases I tried.
Take a look at the test that's failing, hopefully it's unrelated.
perclasson
approved these changes
Jun 9, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
vasilich6107
added a commit
to artflutter/whatsup_flutter_june2020
that referenced
this pull request
Jul 8, 2020
Scale input decorator label width
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a text field is empty and unfocused, a label will be truncated with ellipsis if it is too long.
When the text field is focused, a floating label will be scaled down by a factor of 0.75, but so is its width. This means the label doesn't use available space. This PR fixes this behavior by scaling the label width.
Before:
After:
Related Issues
Closes #56848
Tests
Added a test to verify that the label width scales when focused
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.