Skip to content

Extract a Listenable base class from Animation and ChangeNotifier #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abarth merged 1 commit into from
Sep 15, 2016
Merged

Extract a Listenable base class from Animation and ChangeNotifier #5889

abarth merged 1 commit into from
Sep 15, 2016

Conversation

@abarth
Copy link
Contributor

@abarth abarth commented Sep 15, 2016

Having this base class lets classes like CustomPainter and DataTableSource be
more agnostic as to what's generating the repaints.

@abarth
Extract a Listenable base class from Animation and ChangeNotifier
0519ad0 
Having this base class lets classes like CustomPainter and DataTableSource be
more agnostic as to what's generating the repaints.
@abarth
Copy link
Contributor Author

abarth commented Sep 15, 2016

@Hixie

dragostis
dragostis approved these changes Sep 15, 2016
View reviewed changes
Copy link
Contributor

@dragostis dragostis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abarth abarth merged commit 0586200 into flutter:master Sep 15, 2016
@abarth abarth deleted the listenable branch September 15, 2016 20:13
Hixie
Hixie reviewed Sep 16, 2016
View reviewed changes
packages/flutter/lib/src/material/time_picker.dart

@override
void dispose() {
_thetaController.dispose();
Copy link
Contributor

@Hixie Hixie Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

Copy link
Contributor Author

@abarth abarth Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just happened to notice that one.

@Hixie
Copy link
Contributor

Hixie commented Sep 16, 2016

LGTM

rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 30, 2018
Roll engine af855e0..46b7793 (3 commits)
3a3349e 
flutter/engine@af855e0...46b7793

git log af855e0..46b7793 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 30, 2018
Closed
@rmistry rmistry mentioned this pull request Jul 30, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 30, 2018
Roll engine af855e0..9336082 (4 commits)
0a5a6bc 
flutter/engine@af855e0...9336082

git log af855e0..9336082 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 30, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 30, 2018
Roll engine af855e0..659e49e (5 commits)
26f4a40 
flutter/engine@af855e0...659e49e

git log af855e0..659e49e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 30, 2018
Roll engine af855e0..cd85329 (6 commits)
0a5ed57 
flutter/engine@af855e0...cd85329

git log af855e0..cd85329 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 30, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 30, 2018
Roll engine af855e0..10effc7 (7 commits)
ef834a1 
flutter/engine@af855e0...10effc7

git log af855e0..10effc7 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 30, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 30, 2018
Roll engine af855e0..430ca29 (8 commits)
9083587 
flutter/engine@af855e0...430ca29

git log af855e0..430ca29 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 31, 2018
Roll engine af855e0..5b09e14 (12 commits)
c1291cf 
flutter/engine@af855e0...5b09e14

git log af855e0..5b09e14 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909)
2018-07-30 [email protected] Add word movement granularities to android (flutter#5902)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908)
2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 31, 2018
Closed
@rmistry rmistry mentioned this pull request Jul 31, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 31, 2018
Roll engine af855e0..3e6b681 (13 commits)
f0e0429 
flutter/engine@af855e0...3e6b681

git log af855e0..3e6b681 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909)
2018-07-30 [email protected] Add word movement granularities to android (flutter#5902)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908)
2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 31, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 31, 2018
Roll engine af855e0..d06e9e8 (14 commits)
e3ed4a9 
flutter/engine@af855e0...d06e9e8

git log af855e0..d06e9e8 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-31 [email protected] Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (flutter#18886) (flutter#5858)
2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909)
2018-07-30 [email protected] Add word movement granularities to android (flutter#5902)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908)
2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 31, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 31, 2018
Roll engine af855e0..91ff524 (15 commits)
f7a50b4 
flutter/engine@af855e0...91ff524

git log af855e0..91ff524 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 74c6ed3d1f17..1935aa3d27cd (11 commits) (flutter#5911)
2018-07-31 [email protected] Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (flutter#18886) (flutter#5858)
2018-07-31 37626415&flutter#43;[email protected] Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter#5910)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter#5909)
2018-07-30 [email protected] Add word movement granularities to android (flutter#5902)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter#5908)
2018-07-30 [email protected] Remove the &flutter#34;VSYNC&flutter#34; trace event on Fuchsia (flutter#5907)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter#5906)
2018-07-30 [email protected] Replace travis with cirrus (flutter#5899)
2018-07-30 [email protected] Use container and GKE to accelerate build (flutter#5897)
2018-07-30 [email protected] Add docker container generation scripts (flutter#5898)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter#5905)
2018-07-30 [email protected] Clear the EGL context only if our context is currently active (flutter#5895)
2018-07-30 [email protected] Return proper JSON-RPC error responses from service protocol failures (flutter#5889)
2018-07-30 37626415&flutter#43;[email protected] Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter#5904)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Hixie left review comments

+1 more reviewer

@dragostis dragostis dragostis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abarth @Hixie @dragostis