Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jun 6, 2020

Description

Adds support for --bundle-sksl-path to windows, linux, macOS, and iOS.

Fixes #53115

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 6, 2020
@jonahwilliams
Copy link
Contributor Author

Even though this allows using bundle-sksl on desktop platforms, in local testing this is leading to a black frame on startup. Possibly because #58882 means I used an Android bundle.

@liyuqian

@jonahwilliams
Copy link
Contributor Author

actually nevermind, that black frame is there regardless

@jonahwilliams jonahwilliams merged commit ec4049e into flutter:master Jun 9, 2020
@jonahwilliams jonahwilliams deleted the add_sksl_ios branch June 9, 2020 18:15
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
…rgets (flutter#58879)

Adds support for --bundle-sksl-path to windows, linux, macOS, and iOS.

Fixes flutter#53115
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
…rgets (flutter#58879)

Adds support for --bundle-sksl-path to windows, linux, macOS, and iOS.

Fixes flutter#53115
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for --sksl-shader-warmup to package sksl files into flutter_assets

4 participants