Update framework to account from engine API changes #5887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Depends on an engine roll that isn't quite ready. |
Hixie
approved these changes
Sep 15, 2016
Contributor
Hixie
left a comment
Hixie
left a comment
There was a problem hiding this comment.
LGTM so long as you actually tested it on a real device and checked that it basically works. :-) (I don't trust that our tests would catch issues here. In particular, most of them run with dpr=1.0)
Contributor
There was a problem hiding this comment.
what's a device physical? :-)
abarth
force-pushed
the
update_api
branch
3 times, most recently
from
b45c92a to
aa75f4e
Compare
The engine now reports coordinates in physical pixels.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...27c9de5 git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...27c9de5 git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 27, 2018
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...27c9de5 git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 27, 2018
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...27c9de5 git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...9420da1 git log 6f7bdc9..9420da1 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888) 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry
pushed a commit
to rmistry/flutter
that referenced
this pull request
Jul 27, 2018
flutter/engine@6f7bdc9...9420da1 git log 6f7bdc9..9420da1 --date=short --no-merges --format='%%ad %%ae %%s' 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888) 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739) 2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885) The AutoRoll server is located here: http://localhost:8000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jul 27, 2018
72a38a6 Build Android engine in presubmit using Cirrus and GCE (flutter#5882) f9f40ba Log uncaught exceptions from JNI calls at a higher priority (flutter#5891) 723b278 Update license script README (flutter#5890) 9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888) 27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887) 8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886) 89602cc [scenic] Expose compositor context from rasterizer. (flutter#5739) 9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
liyuqian
added a commit
that referenced
this pull request
Jul 28, 2018
72a38a6 Build Android engine in presubmit using Cirrus and GCE (#5882) f9f40ba Log uncaught exceptions from JNI calls at a higher priority (#5891) 723b278 Update license script README (#5890) 9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (#5888) 27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (#5887) 8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (#5886) 89602cc [scenic] Expose compositor context from rasterizer. (#5739) 9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (#5885)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine now reports coordinates in physical pixels.