Skip to content

Removed magical color. #5886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dragostis merged 1 commit into from
Sep 15, 2016
Merged

Removed magical color. #5886

dragostis merged 1 commit into from
Sep 15, 2016

Conversation

@dragostis
Copy link
Contributor

@dragostis dragostis commented Sep 15, 2016

Changed drawer header to use theme's divider color.

@eseidelGoogle eseidelGoogle changed the title Rmoved magical color. Removed magical color. Sep 15, 2016
HansMuller
HansMuller approved these changes Sep 15, 2016
View reviewed changes
packages/flutter/lib/src/material/drawer_header.dart Outdated
Copy link
Contributor

@HansMuller HansMuller Sep 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code uses Theme.of() twice, create a final ThemeData variable.

@HansMuller
Copy link
Contributor

HansMuller commented Sep 15, 2016

LGTM

@dragostis
Rmoved magical color.
4ed24dc 
Changed drawer header to use theme's divider color.
@dragostis dragostis merged commit ab46cc2 into flutter:master Sep 15, 2016
@dragostis dragostis mentioned this pull request Sep 15, 2016
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 95e91e3..8b8c52e (36 commits)
2622acf 
flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 [email protected] Fix compilation trace memory management problem
2018-07-26 [email protected] Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 [email protected] Roll buildroot to 4fd7a27 (flutter#5880)
2018-07-26 [email protected] Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 [email protected] Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 [email protected] Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 [email protected] Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 [email protected] Support hot reload in corejit mode (flutter#5866)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 [email protected] Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 [email protected] Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 [email protected] Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 [email protected] Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 [email protected] Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 [email protected] Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 [email protected] Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 [email protected] Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 [email protected] Rename clip mode to clip behavior (flutter#5853)
2018-07-25 [email protected] Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415&flutter#43;[email protected] Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415&flutter#43;[email protected] Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 [email protected] Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 95e91e3..8b8c52e (36 commits)
69c68bf 
flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 [email protected] Fix compilation trace memory management problem
2018-07-26 [email protected] Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 [email protected] Roll buildroot to 4fd7a27 (flutter#5880)
2018-07-26 [email protected] Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 [email protected] Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 [email protected] Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 [email protected] Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 [email protected] Support hot reload in corejit mode (flutter#5866)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 [email protected] Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 [email protected] Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 [email protected] Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 [email protected] Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 [email protected] Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 [email protected] Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 [email protected] Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 [email protected] Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 [email protected] Rename clip mode to clip behavior (flutter#5853)
2018-07-25 [email protected] Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415&flutter#43;[email protected] Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415&flutter#43;[email protected] Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 [email protected] Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 27, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 6f7bdc9..27c9de5 (4 commits)
dceb3d3 
flutter/engine@6f7bdc9...27c9de5

git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887)
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 6f7bdc9..27c9de5 (4 commits)
7dbe771 
flutter/engine@6f7bdc9...27c9de5

git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887)
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 27, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 6f7bdc9..27c9de5 (4 commits)
f6acc83 
flutter/engine@6f7bdc9...27c9de5

git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887)
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
This was referenced Jul 27, 2018
Closed
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 6f7bdc9..27c9de5 (4 commits)
7300747 
flutter/engine@6f7bdc9...27c9de5

git log 6f7bdc9..27c9de5 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887)
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 27, 2018
Closed
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 6f7bdc9..9420da1 (5 commits)
f26001a 
flutter/engine@6f7bdc9...9420da1

git log 6f7bdc9..9420da1 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888)
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887)
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 6f7bdc9..9420da1 (5 commits)
047730b 
flutter/engine@6f7bdc9...9420da1

git log 6f7bdc9..9420da1 --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888)
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887)
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 27, 2018
Closed
liyuqian added a commit to liyuqian/flutter that referenced this pull request Jul 27, 2018
@liyuqian
Roll engine to 72a38a6
f9e3573 
72a38a6 Build Android engine in presubmit using Cirrus and GCE (flutter#5882)
f9f40ba Log uncaught exceptions from JNI calls at a higher priority (flutter#5891)
723b278 Update license script README (flutter#5890)
9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888)
27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887)
8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
89602cc [scenic] Expose compositor context from rasterizer. (flutter#5739)
9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
@liyuqian liyuqian mentioned this pull request Jul 27, 2018
Merged
liyuqian added a commit that referenced this pull request Jul 28, 2018
@liyuqian
Roll engine to 72a38a6 (#19923)
f2a983f 
72a38a6 Build Android engine in presubmit using Cirrus and GCE (#5882)
f9f40ba Log uncaught exceptions from JNI calls at a higher priority (#5891)
723b278 Update license script README (#5890)
9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (#5888)
27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (#5887)
8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (#5886)
89602cc [scenic] Expose compositor context from rasterizer. (#5739)
9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (#5885)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dragostis @HansMuller