Skip to content

migrate hot reload benchmark to the new devicelab framework #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yjbanov merged 1 commit into from
Sep 19, 2016
Merged

migrate hot reload benchmark to the new devicelab framework #5878

yjbanov merged 1 commit into from
Sep 19, 2016

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Sep 15, 2016

@johnmccutchan
Copy link
Contributor

johnmccutchan commented Sep 15, 2016

LGTM once you fix the analyzer lints.

What's the context here? Why is this being moved?

@yjbanov
Copy link
Contributor Author

yjbanov commented Sep 15, 2016

Context: I'm moving all our CI tests, including benchmarks, into the main repository so they can be fixed simultaneously with the code that's being tested and also so that it's easier to reproduce breakages and verify fixes.

More info here: https://github.com/flutter/flutter/tree/master/dev/devicelab

@johnmccutchan
Copy link
Contributor

johnmccutchan commented Sep 15, 2016

SGTM. And again LGTM after fixing the analyzer errors.

@yjbanov yjbanov force-pushed the move-hot-reload-benchmark branch from 01ab40a to 2cb5566 Compare September 19, 2016 15:52
@yjbanov yjbanov merged commit 921287b into flutter:master Sep 19, 2016
liyuqian added a commit to liyuqian/flutter that referenced this pull request Jul 26, 2018
@liyuqian
Roll engine to dbd2f57
41be7e7 
dbd2f57 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
76e9f79 Only check trailing spaces for dart and don't check for CRLF (flutter#5877)
9f8285a Remove all dependencies on Garnet. (flutter#5869)
503ba7c Dart SDK roll for 2018/07/26 (flutter#5876)
2c6fa0d Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
f480e32 Support hot reload in corejit mode (flutter#5866)
66f87f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2193ff4 Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
aef291b Unify trailing spaces / new lines (flutter#5871)
6193743 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
7624c8a Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
cfcb701 Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
1d1c8c7 Rename clip to clipBehavior in compositing.dart (flutter#5868)
d559afb Support customizing standard accessibility actions on Android. (flutter#5823)
228cecc Make //flutter/synchronization Garnet free. (flutter#5865)
336c23f Remove //flutter/glue and use FML directly. (flutter#5862)
@liyuqian liyuqian mentioned this pull request Jul 26, 2018
Closed
liyuqian added a commit to liyuqian/flutter that referenced this pull request Jul 26, 2018
@liyuqian
Roll engine to 896441a
2797735 
896441a Roll buildroot to 4fd7a27 (flutter#5880)
de206ea Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
dbd2f57 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
76e9f79 Only check trailing spaces for dart and don't check for CRLF (flutter#5877)
9f8285a Remove all dependencies on Garnet. (flutter#5869)
503ba7c Dart SDK roll for 2018/07/26 (flutter#5876)
2c6fa0d Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
f480e32 Support hot reload in corejit mode (flutter#5866)
66f87f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2193ff4 Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
aef291b Unify trailing spaces / new lines (flutter#5871)
6193743 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
7624c8a Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
cfcb701 Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
1d1c8c7 Rename clip to clipBehavior in compositing.dart (flutter#5868)
d559afb Support customizing standard accessibility actions on Android. (flutter#5823)
228cecc Make //flutter/synchronization Garnet free. (flutter#5865)
336c23f Remove //flutter/glue and use FML directly. (flutter#5862)
@liyuqian liyuqian mentioned this pull request Jul 26, 2018
Closed
@jonahwilliams jonahwilliams mentioned this pull request Jul 27, 2018
Merged
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 95e91e3..8b8c52e (36 commits)
2622acf 
flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 [email protected] Fix compilation trace memory management problem
2018-07-26 [email protected] Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 [email protected] Roll buildroot to 4fd7a27 (flutter#5880)
2018-07-26 [email protected] Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 [email protected] Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 [email protected] Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 [email protected] Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 [email protected] Support hot reload in corejit mode (flutter#5866)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 [email protected] Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 [email protected] Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 [email protected] Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 [email protected] Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 [email protected] Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 [email protected] Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 [email protected] Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 [email protected] Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 [email protected] Rename clip mode to clip behavior (flutter#5853)
2018-07-25 [email protected] Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415&flutter#43;[email protected] Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415&flutter#43;[email protected] Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 [email protected] Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
rmistry pushed a commit to rmistry/flutter that referenced this pull request Jul 27, 2018
Roll engine 95e91e3..8b8c52e (36 commits)
69c68bf 
flutter/engine@95e91e3...8b8c52e

git log 95e91e3..8b8c52e --date=short --no-merges --format='%%ad %%ae %%s'
2018-07-27 37626415&flutter#43;[email protected] Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
2018-07-26 [email protected] [scenic] Expose compositor context from rasterizer. (flutter#5739)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia f27b479f957d..5f1dc76d0cec (1 commits) (flutter#5884)
2018-07-26 [email protected] Fix compilation trace memory management problem
2018-07-26 [email protected] Revert &flutter#34;Dart SDK roll for 2018/07/26 (flutter#5876)&flutter#34; (flutter#5881)
2018-07-26 [email protected] Roll buildroot to 4fd7a27 (flutter#5880)
2018-07-26 [email protected] Update GetDirectoryName namespace to the one in FML on Linux. (flutter#5879)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (flutter#5878)
2018-07-26 [email protected] Only check trailing spaces for dart and don&flutter#39;t check for CRLF (flutter#5877)
2018-07-26 [email protected] Remove all dependencies on Garnet. (flutter#5869)
2018-07-26 [email protected] Dart SDK roll for 2018/07/26 (flutter#5876)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (flutter#5875)
2018-07-26 [email protected] Support hot reload in corejit mode (flutter#5866)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (flutter#5874)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (flutter#5873)
2018-07-26 [email protected] Unify trailing spaces / new lines (flutter#5871)
2018-07-26 37626415&flutter#43;[email protected] Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (flutter#5872)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (flutter#5870)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (flutter#5867)
2018-07-25 [email protected] Rename clip to clipBehavior in compositing.dart (flutter#5868)
2018-07-25 [email protected] Support customizing standard accessibility actions on Android. (flutter#5823)
2018-07-25 [email protected] Make //flutter/synchronization Garnet free. (flutter#5865)
2018-07-25 [email protected] Remove //flutter/glue and use FML directly. (flutter#5862)
2018-07-25 [email protected] Package Skia licenses into a separate file from other third party libraries (flutter#5861)
2018-07-25 [email protected] Pass touch events to embedded Android views with dispatchTouchEvents.
2018-07-23 [email protected] Synthesize Android MotionEvents with the long form obtain method.
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 396661825f45..1c94a8fabed7 (8 commits) (flutter#5859)
2018-07-25 [email protected] Rename clip mode to clip behavior (flutter#5853)
2018-07-25 [email protected] Make the virtual display&flutter#39;s presentation window non focusable. (flutter#5845)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia c062b6be5a01..396661825f45 (3 commits) (flutter#5857)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 15020ea2cf44..c062b6be5a01 (1 commits) (flutter#5856)
2018-07-25 37626415&flutter#43;[email protected] Roll src/third_party/skia 4c7a750e5543..15020ea2cf44 (1 commits) (flutter#5855)
2018-07-24 37626415&flutter#43;[email protected] Roll src/third_party/skia 75e5406be66a..4c7a750e5543 (2 commits) (flutter#5854)
2018-07-24 37626415&flutter#43;[email protected] Roll src/third_party/skia b8eeb808d84f..75e5406be66a (17 commits) (flutter#5852)
2018-07-24 [email protected] Remove check_roll from Travis (flutter#5846)

The AutoRoll server is located here: http://localhost:8000

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&flutter#39;d on the roll, and stop the roller if necessary.
@rmistry rmistry mentioned this pull request Jul 27, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yjbanov @johnmccutchan