-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once #58686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fluttergithubbot
merged 33 commits into
flutter:master
from
AlexV525:fix-zoom-page-transition-build
Jun 17, 2020
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
f0644f0
:sparkles: Add `DualTransitionBuilder`.
AlexV525 02f808e
:recycle: Refactored `_ZoomPageTransition` with `DualTransitionBuilder`.
AlexV525 955ee43
:page_facing_up: :speech_balloon: :art: Updated license & documentati…
AlexV525 b80465b
:label: Reword `Tween`s.
AlexV525 ced9cfd
:label: Reword more properties.
AlexV525 ba8fe04
:rocket: Make reverse animation works normally.
AlexV525 7bbe91b
:art: Use `kAlwaysCompleteAnimation` and `kAlwaysDismissedAnimation`.
AlexV525 dd835df
:pencil2: Fix typos and formats.
AlexV525 32421f9
:white_check_mark: Add build times count test.
AlexV525 0781f5e
:art: Split files import.
AlexV525 33d4fa2
:bulb: Explain the animation status in more detail.
AlexV525 8b6a997
:art: Add key parameter to widgets.
AlexV525 075b214
:rocket: Hide `DualTransitionBuilder`.
AlexV525 ca86a62
:ok_hand: `isCompleted` -> `isNotForward`, `isDismissed` -> `isNotRev…
AlexV525 7af2498
:white_check_mark: Add dual transition builder test.
AlexV525 17894ad
Fix scale and fade transitions
shihaohong 1e9a04a
Fix up transitions to use DualTransitionBuilder
shihaohong 1a28846
Fix import
shihaohong afe0d55
Code formatting cleanup
shihaohong 0d45454
Merge pull request #1 from shihaohong/AlexVincent525-fix-zoom-page-tr…
AlexV525 23271f0
:rewind: Revert "Fix import"
AlexV525 38ebf2f
:label: Reword transitions.
AlexV525 3143465
:art: Add new line at the end of line.
AlexV525 01cb825
:label: Add key property for transitions.
AlexV525 5cf2342
:art: Update assertions & indentation for transitions.
AlexV525 67ab739
:zap: Using `AnimatedBuilder` to ensure the container gets rebuild.
AlexV525 27af148
:art: Adjust widgets import.
AlexV525 54417be
:speech_balloon: Rewords comment and definition.
AlexV525 3ce561a
Merge branch 'master' into fix-zoom-page-transition-build
AlexV525 3ddb0ca
:alien: nnbd updates.
AlexV525 07ba509
:speech_balloon: Reword description for zoom forward transition.
AlexV525 26345f1
:pencil: Complete documentation for the transition.
AlexV525 bfafedb
:ok_hand: Update comment for the constructor.
AlexV525 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.