Skip to content

Flutter 1.17.2 cherrypicks #58050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcsosinski merged 9 commits into from
May 28, 2020
Merged

Flutter 1.17.2 cherrypicks #58050

pcsosinski merged 9 commits into from
May 28, 2020

Conversation

@pcsosinski
Copy link

@pcsosinski pcsosinski commented May 26, 2020 •
edited
Loading

Engine hash: b851c718295a896918dc93cb1ff14f2f895a1b90

@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.17-candidate.3 to master May 26, 2020 23:29
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 26, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels May 26, 2020
@pcsosinski pcsosinski changed the base branch from master to flutter-1.17-candidate.3 May 26, 2020 23:30
@pcsosinski pcsosinski self-assigned this May 26, 2020
@iapicca iapicca mentioned this pull request May 27, 2020
Closed
@pcsosinski pcsosinski marked this pull request as ready for review May 27, 2020 20:01
@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.17-candidate.3 to master May 27, 2020 20:01
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 27, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@pcsosinski pcsosinski changed the base branch from master to flutter-1.17-candidate.3 May 27, 2020 20:02
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos labels May 28, 2020
@pcsosinski pcsosinski changed the title Flutter 1.17.3 cherrypicks Flutter 1.17.2 cherrypicks May 28, 2020
@pcsosinski pcsosinski merged commit 5f21edf into flutter:flutter-1.17-candidate.3 May 28, 2020
@pcsosinski pcsosinski deleted the flutter-1.17-candidate.3 branch May 28, 2020 19:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pcsosinski pcsosinski

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@pcsosinski @fluttergithubbot @tvolkert @googlebot @LongCatIsLooong @pedromassango @christopherfujino @jason-simmons @stuartmorgan-g @jmagman