Skip to content

Remove MaterialControls from examples/flutter_view #57621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 3 commits into from
May 19, 2020
Merged

Remove MaterialControls from examples/flutter_view #57621

jmagman merged 3 commits into from
May 19, 2020

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented May 19, 2020 •
edited
Loading

Description

The repo backing this pod no longer exists, so this switches to a
UIButton. It's currently very ugly, but it builds, and thus won't keep
the tree closed.

Related Issues

#57622

Tests

It builds now.

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@stuartmorgan-g
Remove MaterialControls from examples/flutter_view
f8d0294 
The repo backing this pod no longer exists, so this switches to a
UIButton. It's currently very ugly, but it builds, and thus won't keep
the tree closed.
@stuartmorgan-g stuartmorgan-g requested a review from jmagman May 19, 2020 23:30
@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 19, 2020
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 19, 2020
Open
jmagman
jmagman reviewed May 19, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to delete:

flutter/dev/devicelab/bin/tasks/flutter_view_ios__start_up.dart

Lines 19 to 27 in 088fa24

await inDirectory(iosDirectory, () async {
await exec(
'pod',
<String>['install'],
environment: <String, String>{
'LANG': 'en_US.UTF-8',
},
);
});

@jmagman
Copy link
Member

jmagman commented May 19, 2020

Stealing this.

@jmagman jmagman requested a review from christopherfujino May 19, 2020 23:42
@jmagman
Copy link
Member

jmagman commented May 19, 2020 

Task result:
{
  "success": true,
  "data": {
    "engineEnterTimestampMicros": 98654758265,
    "timeToFrameworkInitMicros": 60562,
    "timeToFirstFrameRasterizedMicros": 142760,
    "timeToFirstFrameMicros": 94639,
    "timeAfterFrameworkInitMicros": 34077
  },
  "benchmarkScoreKeys": []
}


═════════════╡ ••• Finished task "flutter_view_ios__start_up" ••• ╞═════════════

christopherfujino
christopherfujino approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented May 19, 2020

Greening out the tree.

@jmagman jmagman merged commit e384757 into flutter:master May 19, 2020
christopherfujino pushed a commit that referenced this pull request May 27, 2020
@stuartmorgan-g @jmagman @christopherfujino
Remove MaterialControls from examples/flutter_view (#57621)
12d83a8 
Co-authored-by: Jenn Magder <[email protected]>
christopherfujino added a commit that referenced this pull request May 28, 2020
@christopherfujino
Revert "Remove MaterialControls from examples/flutter_view (#57621)"
75b13f7 
This reverts commit 12d83a8. That
commit was accidentally pushed to the wrong branch.
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request May 28, 2020
@stuartmorgan-g @jmagman
Remove MaterialControls from examples/flutter_view (flutter#57621)
6ba9ad1 
Co-authored-by: Jenn Magder <[email protected]>
pcsosinski pushed a commit that referenced this pull request May 28, 2020
@LongCatIsLooong @pedromassango
@christopherfujino @jason-simmons @stuartmorgan-g @jmagman
Flutter 1.17.2 cherrypicks (#58050)
5f21edf 
* fix segment hit test behavior (#57461)

* Making DropdownButtonFormField to re-render if parent widget changes (#57037)

* Update DropdownButtonFormField's state if widget updates

Co-authored-by: Shi-Hao Hong <[email protected]>

* throw more specific toolexit when git fails during upgrade (#57162)

* [flutter_tools] Refresh VM state before executing hot reload (#53960)

* Update engine hash for 1.17.2

* Remove MaterialControls from examples/flutter_view (#57621)

Co-authored-by: Jenn Magder <[email protected]>

* Prevent building non-android plugins in build aar (#58018)

* Allow FLUTTER_APPLICATION_PATH to be null for misconfigured Xcode projects (#57701)

* Don't import plugins that don't support android in settings.gradle (#54407)

Co-authored-by: LongCatIsLooong <[email protected]>
Co-authored-by: Pedro Massango <[email protected]>
Co-authored-by: Shi-Hao Hong <[email protected]>
Co-authored-by: Christopher Fujino <[email protected]>
Co-authored-by: Jason Simmons <[email protected]>
Co-authored-by: stuartmorgan <[email protected]>
Co-authored-by: Jenn Magder <[email protected]>
Co-authored-by: Emmanuel Garcia <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman jmagman left review comments

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stuartmorgan-g @jmagman @christopherfujino @googlebot @fluttergithubbot