Skip to content

Conversation

@JoseAlba
Copy link
Contributor

@JoseAlba JoseAlba commented May 18, 2020

Description

Slider value indicator gets disposed even if the value indicator is active. Currently if the Slider gets removed while it is activated than the value indicator remains on the Overlay.

Related Issues

Closes #55787

Tests

I added the following tests:

flutter/packages/flutter/test/material/slider_test.dart

test using context 'Slider removes value indicator from overlay if Slider gets disposed without value indicator animation completing.'

flutter/packages/flutter/test/material/range_slider_test.dart

test using context 'Range Slider removes value indicator from overlay if Slider gets disposed without value indicator animation completing.'

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 18, 2020
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@JoseAlba
Copy link
Contributor Author

@JoseAlba JoseAlba changed the title [WIP] Slider value indicator gets disposed if it is activated Slider value indicator gets disposed if it is activated May 20, 2020
@JoseAlba JoseAlba requested a review from HansMuller May 20, 2020 21:44
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit bd06749 into flutter:master May 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slider Leaves Value Indicator In Overlay

5 participants