-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Slider value indicator gets disposed if it is activated #57535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider value indicator gets disposed if it is activated #57535
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Slider value indicator gets disposed even if the value indicator is active. Currently if the Slider gets removed while it is activated than the value indicator remains on the Overlay.
Related Issues
Closes #55787
Tests
I added the following tests:
flutter/packages/flutter/test/material/slider_test.darttest using context 'Slider removes value indicator from overlay if Slider gets disposed without value indicator animation completing.'
flutter/packages/flutter/test/material/range_slider_test.darttest using context 'Range Slider removes value indicator from overlay if Slider gets disposed without value indicator animation completing.'
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.