-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[WIP] Migrate Framework to use multi-window API #57178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
c2e0096 to
01abb5c
Compare
01abb5c to
e088751
Compare
e47ff1e to
ad1e13d
Compare
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
a: tests
"flutter test", flutter_test, or one of our tests
c: contributor-productivity
Team-specific productivity, code health, technical debt.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a work-in-progress PR for trying out the multi-window API on the framework repo. The goal here is to convert from the
windowsingleton to an API that has the concept of multiple windows. I'm not attempting to actually enable creating multiple windows here, just migrate to an API that has a concept of multiple windows/screens.I haven't yet updated any docs yet. I wrote some, and copy/pasted a lot all over without making sure they're consistent.
The API design doc for this is here.
The associated engine change is flutter/engine#18368.
Build is expected to fail, since it needs the corresponding engine change to succeed.
Related Issues
Tests
Breaking Change