-
Notifications
You must be signed in to change notification settings - Fork 29.7k
1.18.0-11.1.pre beta cherrypicks #57058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.18.0-11.1.pre beta cherrypicks #57058
Conversation
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.18-candidate.11. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare. /cc @dnfield |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Is this ready for review? |
|
pending flutter/engine#18317 @chenglu can you ack that you're okay with cherrypicking your change here? thank you! |
|
thanks @chenglu I think you need to add a comment that says "@googlebot I consent." |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Upgraded to v 1.17.0 today, fails to build with iOS · Issue #56567 · flutter/flutter
Build --tree-shake-icons option crashes computer · Issue #56473 · flutter/flutter
[Stable v1.17] pushAndRemoveUntil removing initialRoute in navigation stack · Issue #56688 · flutter/flutter
[Suggestion] Migrating Flutter Maven repository to google() · Issue #55134 · flutter/flutter