Skip to content

Conversation

@pcsosinski
Copy link

Upgraded to v 1.17.0 today, fails to build with iOS · Issue #56567 · flutter/flutter

Build --tree-shake-icons option crashes computer · Issue #56473 · flutter/flutter

[Stable v1.17] pushAndRemoveUntil removing initialRoute in navigation stack · Issue #56688 · flutter/flutter

[Suggestion] Migrating Flutter Maven repository to google() · Issue #55134 · flutter/flutter

@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.18-candidate.11 to master May 12, 2020 22:46
@fluttergithubbot
Copy link
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.18-candidate.11. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels May 12, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@pcsosinski pcsosinski requested a review from tvolkert May 12, 2020 22:46
@pcsosinski pcsosinski changed the base branch from master to flutter-1.18-candidate.11 May 12, 2020 22:46
@tvolkert
Copy link
Contributor

Is this ready for review?

@pcsosinski
Copy link
Author

pending flutter/engine#18317

@chenglu can you ack that you're okay with cherrypicking your change here? thank you!

@pcsosinski
Copy link
Author

thanks @chenglu I think you need to add a comment that says "@googlebot I consent."

@chenglu
Copy link
Member

chenglu commented May 13, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@pcsosinski pcsosinski marked this pull request as ready for review May 13, 2020 20:28
@fluttergithubbot fluttergithubbot added the engine flutter/engine related. See also e: labels. label May 13, 2020
@pcsosinski pcsosinski merged commit 2738a11 into flutter:flutter-1.18-candidate.11 May 13, 2020
@pcsosinski pcsosinski deleted the flutter-1.18-candidate.11 branch May 13, 2020 22:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants