Skip to content

Flutter 1.17.1 cherrypicks #57052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcsosinski merged 5 commits into from
May 13, 2020
Merged

Flutter 1.17.1 cherrypicks #57052

pcsosinski merged 5 commits into from
May 13, 2020

Conversation

@pcsosinski
Copy link

@pcsosinski pcsosinski commented May 12, 2020 •
edited
Loading

Upgraded to v 1.17.0 today, fails to build with iOS · Issue #56567 · flutter/flutter

Build --tree-shake-icons option crashes computer · Issue #56473 · flutter/flutter

[Stable v1.17] pushAndRemoveUntil removing initialRoute in navigation stack · Issue #56688 · flutter/flutter

Update engine hash to 6bc433c6b6b5b98dcf4cc11aff31cdee90849f32

e809399 to fix customer_testing-windows

@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.17-candidate.3 to master May 12, 2020 21:27
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 12, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 12, 2020
@pcsosinski pcsosinski requested a review from tvolkert May 12, 2020 21:28
@pcsosinski pcsosinski changed the base branch from master to flutter-1.17-candidate.3 May 12, 2020 21:28
@pcsosinski pcsosinski merged commit f7a6a79 into flutter:flutter-1.17-candidate.3 May 13, 2020
@pcsosinski pcsosinski deleted the flutter-1.17-candidate.3 branch May 26, 2020 23:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pcsosinski @fluttergithubbot @tvolkert @googlebot @jmagman @jonahwilliams @chunhtai