Skip to content

Add mirror overrides to doctor output #56928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
May 11, 2020
Merged

Add mirror overrides to doctor output #56928

jmagman merged 1 commit into from
May 11, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 11, 2020

Description

Show PUB_HOSTED_URL and FLUTTER_STORAGE_BASE_URL in verbose doctor output.

Related Issues

Fixes #56738

Tests

doctor_test

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: flutter doctor Problem related to the "flutter doctor" tool a: triage improvements Make GitHub issues easier to triage and more actionable labels May 11, 2020
@jmagman jmagman requested a review from zanderso May 11, 2020 18:19
@jmagman jmagman self-assigned this May 11, 2020
zanderso
zanderso approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman jmagman merged commit 4ecb1bb into flutter:master May 11, 2020
@jmagman jmagman deleted the mirror branch May 11, 2020 18:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

@jmagman jmagman

Labels

a: triage improvements Make GitHub issues easier to triage and more actionable t: flutter doctor Problem related to the "flutter doctor" tool tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show PUB_HOSTED_URL and FLUTTER_STORAGE_BASE_URL overrides in doctor

3 participants

@jmagman @zanderso @googlebot