Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Description

To be landed and reverted for a cherry pick onto stable.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 11, 2020
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso
Copy link
Member

#56473

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fluttergithubbot fluttergithubbot merged commit dfc955a into flutter:master May 11, 2020
@jonahwilliams jonahwilliams deleted the hide_tsi branch May 11, 2020 19:15
jonahwilliams pushed a commit that referenced this pull request May 11, 2020
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request May 12, 2020
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request May 12, 2020
pcsosinski pushed a commit that referenced this pull request May 13, 2020
* Always remove the workspace settings (#56703)

* [flutter_tools] hide tree-shake-icons (#56924)

* fix pushAndRemoveUntil incorrectly removes the routes below the first… (#56732)

* Update engine hash for 1.17.1

* fix customer_testing-windows

Co-authored-by: Jenn Magder <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: chunhtai <[email protected]>
pcsosinski pushed a commit that referenced this pull request May 13, 2020
* Always remove the workspace settings (#56703)

* [flutter_tools] hide tree-shake-icons (#56924)

* fix pushAndRemoveUntil incorrectly removes the routes below the first… (#56732)

* let the embedding maven engine dependency reference the storage proxy (#56164)

* typo fix on the FLUTTER_STORAGE_BASE_URL usage (#56685)

* Update engine hash for 1.18.0-11.1.pre

Co-authored-by: Jenn Magder <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: chunhtai <[email protected]>
Co-authored-by: xster <[email protected]>
Co-authored-by: Luke Cheng <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants