Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@9b905d3...9d8daf2

git log 9b905d3..9d8daf2 --first-parent --oneline
2020-05-08 [email protected] Roll src/third_party/skia 6913d1bb1d7a..bf1904fd4898 (3 commits) (flutter/engine#18243)
2020-05-08 [email protected] Revert "Remove pipeline in favor of layer tree holder (#17688)" (flutter/engine#18242)
2020-05-08 [email protected] Add fontFeatures and decorationThickness to textstyle (flutter/engine#18235)
2020-05-08 [email protected] Roll src/third_party/dart 617bc54b715d..2a14a62112e6 (30 commits) (flutter/engine#18239)
2020-05-08 [email protected] Roll src/third_party/skia 7359165e660c..6913d1bb1d7a (1 commits) (flutter/engine#18237)
2020-05-08 [email protected] skip font loading tests for safari (flutter/engine#18232)
2020-05-08 [email protected] Roll src/third_party/skia c683912173bb..7359165e660c (1 commits) (flutter/engine#18234)
2020-05-08 [email protected] Publish validation layer deps as part of the fuchsia artifacts (flutter/engine#18214)
2020-05-08 [email protected] make compiler worker count configurable (flutter/engine#17616)
2020-05-08 [email protected] skip painting clipped out pictures (flutter/engine#18204)
2020-05-08 [email protected] Roll src/third_party/skia ac09f7cd7a28..c683912173bb (2 commits) (flutter/engine#18230)
2020-05-08 [email protected] Remove pipeline in favor of layer tree holder (flutter/engine#17688)
2020-05-08 [email protected] Roll src/third_party/skia b55372444d1b..ac09f7cd7a28 (2 commits) (flutter/engine#18229)
2020-05-08 [email protected] Roll src/fuchsia/sdk/mac from 4MCVP... to T5tT0... (flutter/engine#18228)
2020-05-08 [email protected] Roll src/third_party/skia 8f6c3ed7c7be..b55372444d1b (4 commits) (flutter/engine#18224)
2020-05-08 [email protected] Make robolectric tests run against SDK 29 by default (flutter/engine#17996)
2020-05-08 [email protected] Roll src/third_party/skia a14084ba1b41..8f6c3ed7c7be (1 commits) (flutter/engine#18223)
2020-05-08 [email protected] Roll src/fuchsia/sdk/linux from MhpFP... to c1q_S... (flutter/engine#18222)
2020-05-08 [email protected] Add FlMessageCodec, FlBinaryCodec, FlStringCodec (flutter/engine#18186)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

@skia-gold
Copy link

Gold has detected about 1 untriaged digest(s) on patchset 21.
Please triage them at https://flutter-gold.skia.org/search?issue=56740.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite hostonly_devicelab_tests-0-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

Changes to golden files are considered breaking changes, so consult Handling Breaking Changes to proceed. While there are exceptions to this rule, if this patch modifies an existing golden file, it is probably not an exception. Only new golden file tests, or downstream changes like those from skia updates are considered non-breaking.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #56740 at sha 98dc65e

@fluttergithubbot fluttergithubbot added the c: API break Backwards-incompatible API changes label May 9, 2020
@fluttergithubbot fluttergithubbot added the will affect goldens Changes to golden files label May 9, 2020
@GaryQian
Copy link
Contributor

Approved Goldens. Merging.

@GaryQian GaryQian merged commit 1bf3ce0 into flutter:master May 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: API break Backwards-incompatible API changes will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants