Skip to content

Always remove the workspace settings when set to legacy build settings #56703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
May 8, 2020
Merged

Always remove the workspace settings when set to legacy build settings #56703

jmagman merged 1 commit into from
May 8, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 8, 2020 •
edited
Loading

Description

Make #52288 migration more aggressive by always deleting the workspace settings when it's set to the legacy build system. Xcode likes to add keys to this file like PreviewsEnabled.
Reset to defaults by removing this file. There's not usually anything interesting in this file, and Xcode will add whatever it wants next time it opens, but it won't reset the BuildSystemType to Original so this migration will only run once.

Related Issues

#56567 and duplicates.

Tests

Updated ios_project_migration_test.dart

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman requested a review from christopherfujino May 8, 2020 18:21
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 8, 2020
@jmagman jmagman self-assigned this May 8, 2020
christopherfujino
christopherfujino approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 0dc7be3 into flutter:master May 8, 2020
@jmagman jmagman deleted the workspace-migration branch May 8, 2020 19:05
@jmagman jmagman mentioned this pull request May 8, 2020
Closed
@jmagman jmagman linked an issue May 8, 2020 that may be closed by this pull request
Fails to build with iOS: Undefined symbols for architecture x86_64, "_OBJC_CLASS_$..." #56567
Closed
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request May 12, 2020
@jmagman
Always remove the workspace settings (flutter#56703)
a5c279e
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request May 12, 2020
@jmagman
Always remove the workspace settings (flutter#56703)
3ba580e
pcsosinski pushed a commit that referenced this pull request May 13, 2020
@jmagman @jonahwilliams @chunhtai
Flutter 1.17.1 cherrypicks (#57052)
f7a6a79 
* Always remove the workspace settings (#56703)

* [flutter_tools] hide tree-shake-icons (#56924)

* fix pushAndRemoveUntil incorrectly removes the routes below the first… (#56732)

* Update engine hash for 1.17.1

* fix customer_testing-windows

Co-authored-by: Jenn Magder <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: chunhtai <[email protected]>
pcsosinski pushed a commit that referenced this pull request May 13, 2020
@jmagman @jonahwilliams
@chunhtai @xster @chenglu
1.18.0-11.1.pre beta cherrypicks (#57058)
2738a11 
* Always remove the workspace settings (#56703)

* [flutter_tools] hide tree-shake-icons (#56924)

* fix pushAndRemoveUntil incorrectly removes the routes below the first… (#56732)

* let the embedding maven engine dependency reference the storage proxy (#56164)

* typo fix on the FLUTTER_STORAGE_BASE_URL usage (#56685)

* Update engine hash for 1.18.0-11.1.pre

Co-authored-by: Jenn Magder <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: chunhtai <[email protected]>
Co-authored-by: xster <[email protected]>
Co-authored-by: Luke Cheng <[email protected]>
@jmagman jmagman mentioned this pull request May 27, 2020
Open
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@DhavalRKansara DhavalRKansara mentioned this pull request Oct 6, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fails to build with iOS: Undefined symbols for architecture x86_64, "_OBJC_CLASS_$..."

4 participants

@jmagman @christopherfujino @googlebot @fluttergithubbot