Skip to content

Bring back paste button hide behavior #56689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmc merged 2 commits into from
May 8, 2020
Merged

Bring back paste button hide behavior #56689

justinmc merged 2 commits into from
May 8, 2020

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented May 8, 2020 •
edited
Loading

#54902 was reverted by #56614 because it caused an integration test to fail after it was merged. This brings it back.

The only change is to update the android_semantics_test integration test to include a case with/without content on the clipboard.

@justinmc justinmc self-assigned this May 8, 2020
@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 8, 2020
@justinmc justinmc requested a review from goderbauer May 8, 2020 18:24
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 8, 2020
goderbauer
goderbauer approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gotta say, it makes me happy that we have an integration test that caught this! (@jonahwilliams 🎉)

@justinmc justinmc merged commit d563498 into flutter:master May 8, 2020
@justinmc justinmc deleted the pasteable-revert-revert branch May 8, 2020 20:41
@justinmc justinmc mentioned this pull request May 8, 2020
Closed
mehmetf added a commit that referenced this pull request May 10, 2020
@mehmetf
Revert "Bring back paste button hide behavior (#56689)"
52d50a5 
This reverts commit d563498.
@mehmetf mehmetf mentioned this pull request May 10, 2020
Merged
mehmetf added a commit that referenced this pull request May 10, 2020
@mehmetf
Revert "Bring back paste button hide behavior (#56689)" (#56806)
0786f29 
This reverts commit d563498.
@kf6gpe kf6gpe mentioned this pull request May 11, 2020
Closed
justinmc added a commit to justinmc/flutter that referenced this pull request May 11, 2020
@justinmc
Revert "Revert "Bring back paste button hide behavior (flutter#56689)" (
23f1aca 
flutter#56806)"

This reverts commit 0786f29.
@justinmc justinmc mentioned this pull request May 13, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

@justinmc justinmc

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinmc @goderbauer @googlebot @fluttergithubbot