typo fix on the FLUTTER_STORAGE_BASE_URL usage #56685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
Member
|
Ah this looks right. Thanks for the quick fix! We can change this line https://github.com/flutter/flutter/pull/56164/files#diff-d56182dedf1e8eaecb470e8900b4e19eR61 in the test. LGTM |
Member
|
嗯，谢谢程路 |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
xster
approved these changes
May 9, 2020
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
May 12, 2020
pcsosinski
pushed a commit
that referenced
this pull request
May 13, 2020
* Always remove the workspace settings (#56703) * [flutter_tools] hide tree-shake-icons (#56924) * fix pushAndRemoveUntil incorrectly removes the routes below the first… (#56732) * let the embedding maven engine dependency reference the storage proxy (#56164) * typo fix on the FLUTTER_STORAGE_BASE_URL usage (#56685) * Update engine hash for 1.18.0-11.1.pre Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: chunhtai <[email protected]> Co-authored-by: xster <[email protected]> Co-authored-by: Luke Cheng <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small fix to #56164, also @xster .
Since the
FLUTTER_STORAGE_BASE_URLhas been set up to a complete URL like:export FLUTTER_STORAGE_BASE_URL=https://storage.flutter-io.cnhence the scheme
https://which in the maven URL setting should be removed as well as added it to the default setting:storage.googleapis.com,or the final URL will be like:
https://https/storage.flutter-io.cn/download.flutter.ioas Issue #56678 mentioned, which will be connection failed.Related Issues
#55134
Fixes #56678
Tests
Could we use the existing tests that @xster created?
dev/devicelab/bin/tasks/android_engine_dependency_proxy_test.dart
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.