Skip to content

Inject logger and fs into printHowToConsumeAar, test without context #56331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
May 5, 2020
Merged

Inject logger and fs into printHowToConsumeAar, test without context #56331

jmagman merged 1 commit into from
May 5, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 4, 2020

Description

Inject logger and filesystem into printHowToConsumeAar, swap gradle tests to testWithoutContext.

Related Issues

Part of #47161, pre-cursor to #43863

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 4, 2020
@jmagman jmagman requested a review from jonahwilliams May 4, 2020 22:43
@jmagman jmagman self-assigned this May 4, 2020
jonahwilliams
jonahwilliams approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice LGTM!

@jmagman jmagman merged commit 06fcf51 into flutter:master May 5, 2020
@jmagman jmagman deleted the printHowToConsumeAar branch May 5, 2020 01:38
@jmagman jmagman mentioned this pull request May 5, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @jonahwilliams @googlebot