BuildInfo tests without context #56329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
the
c: contributor-productivity
jmagman
commented
May 4, 2020
| buildName = validatedBuildNameForPlatform(TargetPlatform.ios, '123.456.xyz'); | ||
|
|
||
| buildName = validatedBuildNameForPlatform(TargetPlatform.ios, '123.456.xyz', logger); | ||
| expect(logger.traceText, contains('Invalid build-name')); |
| logger = BufferLogger.test(); | ||
| }); | ||
| group('Validate build number', () { | ||
| setUp(() async { }); |
| setUp(() { | ||
| logger = BufferLogger.test(); | ||
| }); | ||
| group('Validate build number', () { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| group('Validate build number', () { | |
| group('Validate build number', () { |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inject logger into BuildInfo methods, swap tests to testWithoutContext.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change