Skip to content

let the embedding maven engine dependency reference the storage proxy #56164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
May 7, 2020
Merged

let the embedding maven engine dependency reference the storage proxy #56164

fluttergithubbot merged 4 commits into from
May 7, 2020

Conversation

@xster
Copy link
Member

@xster xster commented May 2, 2020 •
edited
Loading

Fixes #55134

@xster xster marked this pull request as draft May 2, 2020 00:51
@xster xster marked this pull request as ready for review May 5, 2020 01:10
@xster xster requested a review from blasten May 5, 2020 01:10
@xster
Copy link
Member Author

xster commented May 5, 2020

didn't look like there were any tests that mocked groovy scripts however... any tips?

blasten
blasten approved these changes May 5, 2020
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten
Copy link

blasten commented May 5, 2020 •
edited
Loading

In an integration test, you could probably add an assert in a build.gradle script that checks that project.repositories[..].maven.url equals the one you set via FLUTTER_STORAGE_BASE_URL.

@xster
Copy link
Member Author

xster commented May 6, 2020

added test

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 6, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite customer_testing-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit f6b47a5 into flutter:master May 7, 2020
@xster xster deleted the maven-proxy branch May 7, 2020 19:02
@chenglu chenglu mentioned this pull request May 8, 2020
Merged
13 tasks
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request May 12, 2020
@xster
let the embedding maven engine dependency reference the storage proxy (…
43248ff 
…flutter#56164)
pcsosinski pushed a commit that referenced this pull request May 13, 2020
@jmagman @jonahwilliams
@chunhtai @xster @chenglu
1.18.0-11.1.pre beta cherrypicks (#57058)
2738a11 
* Always remove the workspace settings (#56703)

* [flutter_tools] hide tree-shake-icons (#56924)

* fix pushAndRemoveUntil incorrectly removes the routes below the first… (#56732)

* let the embedding maven engine dependency reference the storage proxy (#56164)

* typo fix on the FLUTTER_STORAGE_BASE_URL usage (#56685)

* Update engine hash for 1.18.0-11.1.pre

Co-authored-by: Jenn Magder <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: chunhtai <[email protected]>
Co-authored-by: xster <[email protected]>
Co-authored-by: Luke Cheng <[email protected]>
@jmagman jmagman mentioned this pull request Jul 21, 2021
Closed
22 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@xster @blasten @fluttergithubbot @googlebot