Repository navigation
don't clear the dirty bit of an inactive node - #5614
Merged
Merged
Conversation
Contributor
Author
|
cc @HansMuller for review @abarth: you might find this one fun |
Contributor
There was a problem hiding this comment.
Assuming that you meant to remove this assert, should we also remove the definition of debugPrintRebuildDirtyWidgets?
Contributor
There was a problem hiding this comment.
Oops, scratch that. I see that you've moved this code below.
Contributor
Author
There was a problem hiding this comment.
Yeah, it was too noisy here. Now it only prints when you rebuild something active and dirty.
Contributor
|
LGTM |
Contributor
Author
|
added a description. I'm not 100% sure it's accurate, but I'm, like, 85% sure. |
Contributor
Author
|
will check in once travis goes green assuming there are no more comments |
Contributor
|
crazy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5588