Repository navigation
[flutter_tools] fix iOS build inconsistencies and pipe through performance file - #56094
Conversation
| -dBuildMode="${build_mode}" \ | ||
| -dTreeShakeIcons="${icon_tree_shaker_flag}" \ | ||
| -dDartObfuscation="${dart_obfuscation_flag}" \ | ||
| -dTreeShakeIcons="${TREE_SHAKE_ICONS}" \ |
There was a problem hiding this comment.
There is no need to conditionally set these flags, assemble just checks if == true, so an empty string if they are unset is fine.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
Hmm @christopherfujino your edit got applied as a gmail address |
Co-authored-by: Christopher Fujino <[email protected]>
93159f0 to
33e636b
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it |
|
The docs linux task did finish successfully |
Description
Ensure iOS and android builds can be correctly cached. Use the performance-measurement-file to verify that all targets were skipped on the second invocation. This is only run on the flutter_gallery build.
When plumbing the flag through I updated the xcode scripts to use the same environment variable logic as linux and windows to simplify the code. I also removed the custom
track-widget-creationflag from build_appbundle in favor of the standard flag. This updated the default in safe/backwards compatible way.Fixes #56086