Fine tune the Y offset of OutlineInputBorder's floating label #55260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter of the top edge of the InputDecorator outline border
fluttergithubbot
added
f: material design
gspencergoog
approved these changes
Apr 21, 2020
| dividerTheme: DividerThemeData.lerp(a.dividerTheme, b.dividerTheme, t), | ||
| buttonBarTheme: ButtonBarThemeData.lerp(a.buttonBarTheme, b.buttonBarTheme, t), | ||
| bottomNavigationBarTheme: BottomNavigationBarThemeData.lerp(a.bottomNavigationBarTheme, b.bottomNavigationBarTheme, t), | ||
| fixTextFieldOutlineLabel: t < 0.5 ? a.fixTextFieldOutlineLabel : b.fixTextFieldOutlineLabel, |
Contributor
There was a problem hiding this comment.
Sure you don't want to lerp the adjustment? :-) (just kidding)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputDecorator: Ensure that the OutlineInputBorder's floating label is vertically centered relative to the center of the top edge of the outline.
Fixes #54028
This fix is temporarily "opt-in": the ThemeData
fixTextFieldOutlineLabelenables the fix.The fixTextFieldOutlineLabel flag will be deprecated and its default value changed to true in a future version of Flutter.
In the image below, fixTextFieldOutlineLabel is false (the default) on the left, true on the right.