-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Prioritize scrolling away nested overscroll #55069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
commented
Apr 20, 2020
goderbauer
approved these changes
Apr 27, 2020
Member
goderbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
13 tasks
9 tasks
9 tasks
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: fidelity
Matching the OEM platforms better
a: quality
A truly polished experience
customer: crowd
Affects or could affect many people, though not necessarily a specific customer.
f: scrolling
Viewports, list views, slivers, etc.
framework
flutter/packages/flutter repository. See also f: labels.
platform-ios
iOS applications specifically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
NestedScrollCoordinatorto prioritize scrolling 'away' any inner overscroll before any of the outer/inner positions. Previously, if you did not lift your finger from the screen and allow the overscroll to bounce back, the overscroll would stick and scroll in between the inner and outer scrollables.Bug behavior:
Fixed behavior:
Related Issues
#29264
#17518
Tests
I updated the nested overscroll related tests. This is not being considered a breaking change. Although existing tests needed to be changed, there was a
TODOstating these expectations when this was fixed. The comments around these tests were acknowledging that the expected behavior was bad. Ran through internal tests and everything passed, customer tests are passing as well. :)Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.