Skip to content

Conversation

@shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Apr 16, 2020

Description

Re-attempt of #52136 due to CI failures unrelated to the PR.

Continuation from #50597, applying the offset fix by default. The PR that follows this will remove the flag altogether, making the fix a default setting and removing the previous, incorrect offset.

Migration guide

  1. Set all instances of Scaffold.shouldSnackBarIgnoreFABRect to true after this PR is merged.
  2. Fix all failing tests. There are likely two main types:
    a) Fix all golden tests to expect the new change.
    b) Fix any widget tests that expect the SnackBar to appear higher than it should. The difference should simply be the size of the floating action button's rect.
  3. Once Scaffold.shouldSnackBarIgnoreFABRect is set to true by default (in a subsequent PR), remove the parameter from all instances of Scaffold.

Related Issues

Addresses #47202
Addresses #43716

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 16, 2020
@shihaohong shihaohong requested a review from HansMuller April 16, 2020 20:57
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit 6ce90a9 into flutter:master Apr 16, 2020
@shihaohong shihaohong deleted the snackbar-fix-attempt-2 branch May 14, 2020 00:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants