Skip to content

Conversation

@tauu
Copy link
Contributor

@tauu tauu commented Apr 14, 2020

Description

Currently PRs adding or modifying a pubspec.yaml file face the issue of failing the analyze-linux check without executing flutter upgrade-packages --force-upgrade first. As this changes a lot of files throughout the repository, a separate PR for the upgrade seems appropriate.

This PR is the state of repository after executing flutter upgrade-packages --force-upgrade. The only upgraded package is the path package, which recently published a new version (1.7.0).

Related Issues

#51126 contains a new integration test requiring a package upgrade to pass the analyze-linux check.

Tests

I added the following tests:

  • none

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@tauu tauu requested a review from Piinks as a code owner April 14, 2020 21:48
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 14, 2020
@jmagman
Copy link
Member

jmagman commented Apr 14, 2020

@jonahwilliams this LGTM do you know any reason why this would be an issue? I think you put out the last few PRs to run upgrade-packages.

@jonahwilliams
Copy link
Contributor

Nope, all good!

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 846e8fe into flutter:master Apr 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants