Reland "Add API to services package that overrides HTTP ban (#54243)" #54522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
framework
Contributor
Author
|
@yjbanov please take a look. I tried not to add this test to Web blacklist but I am not sure of the proper way to write tests that should cover both Web and non-web. Is this the pattern to follow? Thanks. |
yjbanov
approved these changes
Apr 13, 2020
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
LGTM with a bunch of nitpicking.
| /// Best Practices: | ||
| /// - Do not wrap your entire app with [allowHttp]. Wrap *exactly* what you need and nothing more. | ||
| /// - Avoid libraries that require accessing HTTP URLs. | ||
| T allowHttp<T>(T action()) { |
Contributor
There was a problem hiding this comment.
Should this sound less benign? Perhaps allowUnsecureHttp?
Contributor
Author
There was a problem hiding this comment.
I think allowHttp is better. It is more consistent with the rest of the platform code and as an API it is less confusing imo (is there a secure http?).
mehmetf
added a commit
that referenced
this pull request
Apr 14, 2020
mehmetf
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is being submitted in preparation of breaking change described in dart-lang/sdk#40548.
The Dart SDK support for this is added dart-lang/sdk@74a20b7.
Following this PR, I will draft and send out an announcement for flutter-announce@. Afterwards, I will submit the change to engine to ban HTTP by default on iOS and Android.
Related Issues
#54448
Tests
I added the following tests:
allowHttp.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.