Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 10, 2020

Description

Remove the com.apple.FinderInfo extended attributes from everything in the iOS project before it builds. This is a speculative fix since I wasn't able to reproduce, but my suspicion is that the xattrs are being added to files in the copied Flutter.framework, which then can't be code signed when it's copied into the Runner.app.

Related Issues

Fixes #49290

Tests

mac_tests

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 10, 2020
@jmagman jmagman self-assigned this Apr 10, 2020
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App won't run on ios simulator/ resource fork, Finder information, or similar detritus not allowed

3 participants