Allow ListTiles to be autofocused#54229
Merged
Merged
Conversation
This is important for scenarios like a settings screen, where the first interactable element on a page may be a SwitchListTile, for example.
gspencergoog
reviewed
Apr 7, 2020
| this.onTap, | ||
| this.onLongPress, | ||
| this.selected = false, | ||
| this.autofocus = false, |
Contributor
There was a problem hiding this comment.
How about also adding focusColor, hoverColor, and focusNode here, for parity with other widgets? You'd just have to pass them to the InkWell, so there's nothing to implement, really.
You're welcome to crib the tests for the colors from here: https://github.com/flutter/flutter/pull/53888/files#diff-557cb6cb0346a07994b565cb2a524544R1191
Contributor
There was a problem hiding this comment.
Also, of course, if you don't have time for that, I'm happy to just add them in mine.
Contributor
Author
There was a problem hiding this comment.
Yes, could you please add them in yours? It might take me a while to add those to all 4 classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an "autofocus" param to ListTile and its Checkbox, Radio and Switch variants, and passes the given value through to the wrapped InkWell, Switch, etc.
This is important for scenarios like a settings screen, where the first interactable element on a page may be a SwitchListTile, for example.
Related Issues
N/A (trivial effort)
Tests
I added the following tests:
Added a test to each class that verifies setting the new autofocus param to true will focus the Tile, unless the tile is disabled.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.