Skip to content

Remove escape dollar parameter in localizations_utils #54219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 8, 2020
Merged

Remove escape dollar parameter in localizations_utils #54219

fluttergithubbot merged 2 commits into from
Apr 8, 2020

Conversation

@shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Apr 7, 2020 •
edited
Loading

Removes the escape dollar flag from generateString, since it is no longer being used by any of the l10n tools as a result of the fix in #54185

@shihaohong shihaohong added the a: internationalization Supporting other languages or locales. (aka i18n) label Apr 7, 2020
@shihaohong shihaohong requested a review from HansMuller April 7, 2020 19:29
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 7, 2020
@shihaohong shihaohong changed the title Remove escape dollar parameter Remove escape dollar parameter in localizations_utils Apr 8, 2020
HansMuller
HansMuller approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 592f788 into flutter:master Apr 8, 2020
@shihaohong shihaohong deleted the remove-escape-dollar branch May 14, 2020 00:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shihaohong @HansMuller @googlebot @fluttergithubbot