Skip to content

Reland "iOS UITextInput autocorrection prompt (#45354)" #54119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Apr 7, 2020
Merged

Reland "iOS UITextInput autocorrection prompt (#45354)" #54119

fluttergithubbot merged 2 commits into from
Apr 7, 2020

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Apr 6, 2020

reverted in #47373

This reverts commit bc67d22.

@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 6, 2020
@LongCatIsLooong LongCatIsLooong force-pushed the reland-autocorrection branch from 7215243 to 2ac4aeb Compare April 6, 2020 19:39
justinmc
justinmc approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chingjun
Copy link
Contributor

chingjun commented Apr 7, 2020

This was reverted because of a new method added that broke our internal clients. I noticed that there's still a class that implements TextInputClient, can you make sure that the internal client will not be broken by this PR? Thanks.

chingjun
chingjun approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@chingjun chingjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 4af5fe2 into flutter:master Apr 7, 2020
@LongCatIsLooong LongCatIsLooong deleted the reland-autocorrection branch April 7, 2020 19:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@justinmc justinmc justinmc approved these changes

@chingjun chingjun chingjun approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LongCatIsLooong @chingjun @justinmc @googlebot @fluttergithubbot