Skip to content

Remove IOSDeploy from globals, hoist to XCDevice constructor #53203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Mar 24, 2020
Merged

Remove IOSDeploy from globals, hoist to XCDevice constructor #53203

jmagman merged 1 commit into from
Mar 24, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 24, 2020

Related Issues

#47161

Tests

XCDevice still has more globals, not ready for testWithoutContext yet.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 24, 2020
@jmagman jmagman self-assigned this Mar 24, 2020
@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 24, 2020
christopherfujino
christopherfujino approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy win!

@jmagman jmagman merged commit c93847d into flutter:master Mar 24, 2020
@jmagman jmagman deleted the ios-deploy branch March 24, 2020 23:50
@jmagman jmagman mentioned this pull request Mar 25, 2020
Merged
10 tasks
@jmagman jmagman mentioned this pull request Jul 17, 2020
Merged
10 tasks
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @christopherfujino @googlebot @fluttergithubbot