Add benchmark for platform views #52717
Conversation
fluttergithubbot
added
c: contributor-productivity
blasten
changed the title
|
|
||
| <application android:name="io.flutter.app.FlutterApplication" android:label="complex_layout" android:icon="@mipmap/ic_launcher"> | ||
| <activity android:name="io.flutter.app.FlutterActivity" | ||
| <activity android:name=".DummyPlatformViewActivity" |
There was a problem hiding this comment.
I think we should avoid touching this file right now - it would probably be better to just create a new benchmark for this rather than touching the existing one, since this is used by several other benchmarks.
I'm particularly worried about what happens if this puts a devicelab device into a bad state right now.
/cc @godofredoc
| <key>io.flutter.embedded_views_preview</key> | ||
| <true/> |
There was a problem hiding this comment.
This should be done in a different application. This will impact other benchmarks besides this one, since it changes the threading model used by the application on iOS.
There was a problem hiding this comment.
This will become the default though. cc @cyanglaz what is the status of that?
There was a problem hiding this comment.
Still have several PRs waiting on different people to reviews. It might take some time as people have limited availability working from home. If you want to land this benchmark soon, we should create a different App.
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Code overall looks good, I'm worried about impact application changes might have on other benchmarks.
|
I created a separate app in the meanwhile. Adding a new app to the flutter repo involves a non-trivial diff, so I tried to reuse as much of the existing one. Once thread merging becomes the new default, |
liyuqian
added
perf: speed
6 participants
Fixes #52684
This PR adds a layout to the complex_layout app, which renders a few dummy platform views and an animated overlay on top of each platform view. The driver test scrolls the list and gathers information such as the 90th percentile frame build time in millisec.