Skip to content

Add SDK location unit tests #52691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Mar 16, 2020
Merged

Add SDK location unit tests #52691

jmagman merged 2 commits into from
Mar 16, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 16, 2020

Description

Add unit tests.

Related Issues

Fixes #46137

Tests

xcode_tests

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 16, 2020
@jmagman jmagman self-assigned this Mar 16, 2020
@jmagman
Copy link
Member Author

jmagman commented Mar 16, 2020

Just the unit tests in #52570 without the SDK env lookup behavior changes.

christopherfujino
christopherfujino reviewed Mar 16, 2020
View reviewed changes
packages/flutter_tools/test/general.shard/macos/xcode_test.dart
Platform: () => macPlatform,
});

testWithoutContext('uses timeout', () async {
Copy link
Contributor

@christopherfujino christopherfujino Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this test removed?

Copy link
Member Author

@jmagman jmagman Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhhhhh whoops, rebase issue.

christopherfujino
christopherfujino approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 93a6057 into flutter:master Mar 16, 2020
@jmagman jmagman deleted the sdk-test branch March 16, 2020 23:02
@lock
Copy link

lock bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add xcode sdkLocation unit tests

3 participants

@jmagman @christopherfujino @googlebot