Skip to content

Make --androidx flag a noop in flutter create#52340

Merged
blasten merged 6 commits intoflutter:masterfrom
blasten:remove_androidx_flag
Mar 11, 2020
Merged

Make --androidx flag a noop in flutter create#52340
blasten merged 6 commits intoflutter:masterfrom
blasten:remove_androidx_flag

Conversation

@blasten
Copy link
Copy Markdown

@blasten blasten commented Mar 10, 2020 •
edited
Loading

Description

Make androidx flag a noop in flutter create. This means that there won't be a way to create a non-androidx project from flutter create.

Related Issues

#39283

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 10, 2020
@blasten blasten mentioned this pull request Mar 10, 2020
Merged
@jonahwilliams
Copy link
Copy Markdown
Contributor

jonahwilliams commented Mar 10, 2020

Were any of the IDEs configured to pass this flag?

@jmagman
Copy link
Copy Markdown
Member

jmagman commented Mar 10, 2020

Needs to be updated in plugin_tools first for plugin CI https://github.com/flutter/plugin_tools/blob/3aea345df9220a42b9094e3034591c95eb3fa815/lib/src/create_all_plugins_app_command.dart#L57

@jmagman
Copy link
Copy Markdown
Member

jmagman commented Mar 10, 2020

Were any of the IDEs configured to pass this flag?

There's a checkmark that adds --no-androidx
https://github.com/flutter/flutter-intellij/blob/82d3aaa8279e44d01073120a68d29dbf3f34cb0f/src/io/flutter/sdk/FlutterCreateAdditionalSettings.java#L133
https://github.com/flutter/flutter-intellij/blob/024b84cb8ec2b723047c7794b3470478448e5fac/testSrc/unit/io/flutter/sdk/FlutterCreateAdditionalSettingsTest.java#L144

@blasten blasten mentioned this pull request Mar 10, 2020
Merged
@blasten
Copy link
Copy Markdown
Author

blasten commented Mar 10, 2020

@stevemessick is it possible to remove the --no-androidx flag?

@stevemessick
Copy link
Copy Markdown
Member

stevemessick commented Mar 10, 2020

Could we do this in two stages? Allow the arg parser to accept the flag but ignore it for now. Once this gets into stable we can remove the flag. Maybe make hidden, too. Would that work? Otherwise we're going to have to do version checking in the IDE when we build that UI.

@blasten
Copy link
Copy Markdown
Author

blasten commented Mar 10, 2020

@stevemessick sgtm

@blasten blasten mentioned this pull request Mar 10, 2020
Closed
jonahwilliams
jonahwilliams approved these changes Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten changed the title Remove --androidx flag from flutter create Make --androidx flag a noop in flutter create Mar 10, 2020
@blasten blasten requested a review from jmagman March 10, 2020 23:21
jmagman
jmagman reviewed Mar 10, 2020
View reviewed changes
@blasten blasten requested a review from jmagman March 11, 2020 00:14
jmagman
jmagman approved these changes Mar 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blasten blasten merged commit 4049889 into flutter:master Mar 11, 2020
@blasten blasten deleted the remove_androidx_flag branch March 11, 2020 03:05
@jmagman jmagman mentioned this pull request Jul 30, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@blasten @jonahwilliams @jmagman @stevemessick @googlebot @fluttergithubbot